FROM : Jens Alfke
DATE : Wed Jul 09 17:27:53 2008
On 9 Jul '08, at 7:44 AM, Chris Paveglio wrote:
> I'm trying to make sure that this part of my code is good and clean
> and not leaking. I believe that I have it right (but still think I
> have something wrong).
It looks OK to me on quick reading. The main thing I'd change is to
put the path strings into a plist, or at least put the string literals
directly into the NSArray initializer lines instead of declaring
separate variables for them, i.e.
myPrefs = [NSArray arrayWithObjects: @"Library/Preferences/Adobe
Photoshop CS3 Settings",
@"Adobe Photoshop CS3 Settings",
..........., nil];
but that's just an issue of style.
—Jens
DATE : Wed Jul 09 17:27:53 2008
On 9 Jul '08, at 7:44 AM, Chris Paveglio wrote:
> I'm trying to make sure that this part of my code is good and clean
> and not leaking. I believe that I have it right (but still think I
> have something wrong).
It looks OK to me on quick reading. The main thing I'd change is to
put the path strings into a plist, or at least put the string literals
directly into the NSArray initializer lines instead of declaring
separate variables for them, i.e.
myPrefs = [NSArray arrayWithObjects: @"Library/Preferences/Adobe
Photoshop CS3 Settings",
@"Adobe Photoshop CS3 Settings",
..........., nil];
but that's just an issue of style.
—Jens






Cocoa mail archive

